Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document): avoid massive perf degradation when saving new doc with 10 level deep subdocs #14910

Merged
merged 5 commits into from
Sep 25, 2024
Merged

fix(document): avoid massive perf degradation when saving new doc with 10 level deep subdocs #14910

merged 5 commits into from
Sep 25, 2024

Conversation

vkarpov15
Copy link
Collaborator

Fix #14897

Summary

Saving a new doc with many very deep subdocs is extremely expensive: the test case in this PR fails after 35 seconds on my local without the change I made to lib/document.js. Saving a new doc 10 levels deep is still more expensive than I'd like, this test now takes maybe 300ms, I'll investigate why this is so slow and add a benchmark.

Examples

hasezoey
hasezoey reviewed Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will this be in the next minor version for caution?

@vkarpov15
Copy link
Collaborator Author

I don't think it is necessary to put this change in a minor release. As far as I can tell, there's no observable difference with the changes in this PR other than perf improvements. Subdoc middleware and getters will still get called normally, this PR just removes a bunch of work.

@vkarpov15
Copy link
Collaborator Author

No meaningful change on insertManySimple benchmark. But createDeepNestedDocArray benchmark difference is massive: 223ms vs 34802ms on master on 10 level deep subdocs. Over 100x speedup 😎

@vkarpov15 vkarpov15 merged commit 34ed360 into master Sep 25, 2024
46 checks passed
@vkarpov15 vkarpov15 added this to the 8.6.4 milestone Sep 25, 2024
@hasezoey hasezoey deleted the vkarpov15/gh-14897 branch September 26, 2024 10:42
@nejidevelops nejidevelops mentioned this pull request Oct 20, 2024
Open
@ShivamNimje6 ShivamNimje6 mentioned this pull request Oct 20, 2024
Open
@zntb zntb mentioned this pull request Oct 21, 2024
Merged
@nejidevelops nejidevelops mentioned this pull request Oct 22, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Oct 23, 2024
Open
@sharma731 sharma731 mentioned this pull request Oct 23, 2024
Open
@axqqt axqqt mentioned this pull request Oct 23, 2024
Open
@zntb zntb mentioned this pull request Oct 24, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Oct 25, 2024
Open
@k2xl k2xl mentioned this pull request Oct 25, 2024
Open
@hamzabetbaieb hamzabetbaieb mentioned this pull request Oct 25, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Oct 25, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Oct 25, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Oct 26, 2024
Open
@yunji0387 yunji0387 mentioned this pull request Oct 26, 2024
Merged
@Gabo-Tech Gabo-Tech mentioned this pull request Oct 27, 2024
Open
@axqqt axqqt mentioned this pull request Oct 27, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 2, 2024
Open
@axqqt axqqt mentioned this pull request Nov 3, 2024
Open
@mihirhbhatt mihirhbhatt mentioned this pull request Nov 3, 2024
Merged
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 3, 2024
Open
@PietroBossolasco PietroBossolasco mentioned this pull request Nov 3, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 4, 2024
Open
@axqqt axqqt mentioned this pull request Nov 4, 2024
Open
@rodrigo3829l rodrigo3829l mentioned this pull request Nov 4, 2024
Open
@KovacevicAleksa KovacevicAleksa mentioned this pull request Nov 5, 2024
Merged
@saileshbro saileshbro mentioned this pull request Nov 5, 2024
Merged
@JasperVanNiekerk JasperVanNiekerk mentioned this pull request Nov 5, 2024
Merged
@MSK-009 MSK-009 mentioned this pull request Nov 5, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Nov 6, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request Nov 6, 2024
Open
@Erenkrs Erenkrs mentioned this pull request Nov 6, 2024
Open
@issam-seghir issam-seghir mentioned this pull request Nov 6, 2024
Open
@saileshbro saileshbro mentioned this pull request Nov 7, 2024
Merged
@Tobsukka Tobsukka mentioned this pull request Nov 8, 2024
Open
@k2xl k2xl mentioned this pull request Nov 8, 2024
Open
@MihikaNigam MihikaNigam mentioned this pull request Nov 8, 2024
Open
@AlexanderSCK AlexanderSCK mentioned this pull request Nov 8, 2024
Open
@AntenehTsegayeTessema AntenehTsegayeTessema mentioned this pull request Nov 8, 2024
Open
@akanchhaS akanchhaS mentioned this pull request Nov 9, 2024
Open
@aviraj1703 aviraj1703 mentioned this pull request Nov 9, 2024
Open
@nejidevelops nejidevelops mentioned this pull request Nov 9, 2024
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
@axqqt axqqt mentioned this pull request Nov 10, 2024
Open
@ibrahim-mohamed-zaghloul ibrahim-mohamed-zaghloul mentioned this pull request Nov 11, 2024
Open
@axqqt axqqt mentioned this pull request Nov 11, 2024
Open
@pradumchintamani pradumchintamani mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasezoey hasezoey hasezoey left review comments

@AbdelrahmanHafez AbdelrahmanHafez Awaiting requested review from AbdelrahmanHafez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.6.4
Development

Successfully merging this pull request may close these issues.

Infinitely hangs inserting complex document with recursive schema
2 participants
@vkarpov15 @hasezoey